fix: drop ill-defined \/ escapes in package.nix version matcher - #79
Merged
Conversation
`"\/"` is not a defined Nix string escape. It evaluates to `/`, so the regex is unchanged, but Lix warns on every evaluation: warning: \/ is an ill-defined escape. You can drop the \ and simply write / instead. Write the slashes literally. The `\\.` escapes are kept — those are real, producing the literal `\.` the regex needs. Fixes #78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78.
"\/"is not a defined escape in the Nix string grammar. It happens to evaluate to/, so the regex behaves correctly, but Lix emits a deprecation warning on every evaluation of the flake:This writes both slashes literally. The
\\.escapes are left alone — those are real, producing the literal\.the regex needs to match a dot rather than any character.Verification
The change is provably behaviour-preserving; the two literals are the same string:
All six flake outputs still evaluate with the versions from #77 intact:
grep -rn '\\/' --include='*.nix' .confirms line 75 was the only such escape in the repo.🤖 Generated with Claude Code